Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/24906 )
Change subject: KUDU-3806: split CLI actions into a library ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/24906/3/src/kudu/tools/tool_action_root.cc File src/kudu/tools/tool_action_root.cc: http://gerrit.cloudera.org:8080/#/c/24906/3/src/kudu/tools/tool_action_root.cc@39 PS3, Line 39: // (KUDU_CLI_TOOL_SRCS / _NO_MAIN), which already provide every factory, so it I think both names in this parenthetical are off: KUDU_CLI_TOOL_SRCS is the variable this commit renames to KUDU_CLI_ACTION_SRCS, and I couldn't find _NO_MAIN anywhere in the tree. Should this just say kudu_cli_actions / KUDU_CLI_ACTION_SRCS? -- To view, visit http://gerrit.cloudera.org:8080/24906 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c47cf1844042fc09493edf18652493742187f03 Gerrit-Change-Number: 24906 Gerrit-PatchSet: 3 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Wed, 23 Sep 2026 12:55:17 +0000 Gerrit-HasComments: Yes
