Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/24905 )
Change subject: KUDU-3806: add deadline-bounded WaitAndCollect() ...................................................................... Patch Set 3: (1 comment) Thanks for working on this! 1 question, otherwise LGTM. http://gerrit.cloudera.org:8080/#/c/24905/3/src/kudu/util/subprocess-test.cc File src/kudu/util/subprocess-test.cc: http://gerrit.cloudera.org:8080/#/c/24905/3/src/kudu/util/subprocess-test.cc@265 PS3, Line 265: ASSERT_OK(p.WaitAndCollect(MonoDelta::FromSeconds(1), : &out, &err, &timed_out, &wait_status)); Could this be flaky? The 1s deadline races fork plus exec of bash plus the two echos, and if setup loses that race both ASSERT_EQs at 269-270 see empty strings. -- To view, visit http://gerrit.cloudera.org:8080/24905 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I582ea89b0ada4f723695df8d98d7e5bc0bbc7f7f Gerrit-Change-Number: 24905 Gerrit-PatchSet: 3 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Wed, 23 Sep 2026 12:39:33 +0000 Gerrit-HasComments: Yes
