Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24863 )
Change subject: KUDU-3761 drop default for prefer_follower_moves ...................................................................... KUDU-3761 drop default for prefer_follower_moves LocationBalancingAlgo requires callers to pass 'prefer_follower_moves' explicitly. TwoDimensionalGreedyAlgo still defaulted it to true, so callers could quietly opt into follower-preferring behavior by leaving the arg off. Drop that default. The trailing EqualSkewOption default goes with it (defaults must be contiguous at the end); update the zero/one-arg call sites in rebalance_algo-test.cc to pass both args. Change-Id: I2a86f1345b3adad084813e1b61a4a38ef566d035 Reviewed-on: http://gerrit.cloudera.org:8080/24863 Reviewed-by: Ashwani Raina <[email protected]> Reviewed-by: Marton Greber <[email protected]> Tested-by: Marton Greber <[email protected]> --- M src/kudu/rebalance/rebalance_algo-test.cc M src/kudu/rebalance/rebalance_algo.h 2 files changed, 37 insertions(+), 12 deletions(-) Approvals: Ashwani Raina: Looks good to me, approved Marton Greber: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/24863 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2a86f1345b3adad084813e1b61a4a38ef566d035 Gerrit-Change-Number: 24863 Gerrit-PatchSet: 5 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]>
