Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24932 )
Change subject: [tablet] make tablet_compaction_budget_mb a runtime flag ...................................................................... Patch Set 1: Code-Review+2 (1 comment) LGTM. Maybe, change the type of the flag to uint32 along with introducing runtime behavior as well? http://gerrit.cloudera.org:8080/#/c/24932/1/src/kudu/tablet/compaction_policy.cc File src/kudu/tablet/compaction_policy.cc: http://gerrit.cloudera.org:8080/#/c/24932/1/src/kudu/tablet/compaction_policy.cc@533 PS1, Line 533: DCHECK_GT(FLAGS_tablet_compaction_budget_mb, 0); : size_budget_mb_ = FLAGS_tablet_compaction_budget_mb; Since size_budget_mb_ is of size_t type, maybe it's easier to change the type of the the flag from int32 to uint32 and remove DCHECK/CHECK: isn't not a problem setting it to 0, IIUC. -- To view, visit http://gerrit.cloudera.org:8080/24932 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0515daff32d952cc9dc45d604cf41bf6018d403 Gerrit-Change-Number: 24932 Gerrit-PatchSet: 1 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 25 Sep 2026 05:57:08 +0000 Gerrit-HasComments: Yes
