Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/24907 )
Change subject: KUDU-3806: classify CLI actions for the MCP server ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/24907/4/src/kudu/tools/mcp_disposition-test.cc File src/kudu/tools/mcp_disposition-test.cc: http://gerrit.cloudera.org:8080/#/c/24907/4/src/kudu/tools/mcp_disposition-test.cc@104 PS4, Line 104: ResolvePath(root, path, &chain, &action); I might be misreading this, but I think a failing lookup here takes the binary down rather than failing the test. If ASSERT_NE at line 96 fails, it prints "no action '...'" and then returns from ResolvePath(). Because a fatal assertion is just a return, it ends the helper and nothing else, so the test body carries on. Line 97 never runs, which means action still holds the null it was given at line 103. We pass that null to DispositionFor(), and it reads through the pointer at mcp_disposition.cc:98-99, so we get a SIGSEGV and the remaining tests in this binary never run. It only shows up once an action is renamed or removed, so I don't think it's urgent. Line 203 calls ResolvePath() directly too, so it has the same shape. -- To view, visit http://gerrit.cloudera.org:8080/24907 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I29aaf7910198c33589438638140fbb8e8cc5a695 Gerrit-Change-Number: 24907 Gerrit-PatchSet: 4 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Fri, 25 Sep 2026 13:21:35 +0000 Gerrit-HasComments: Yes
