Alexey Serbin has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/24964 )
Change subject: [thirdparty] fix Postgres memset_s() build issue on macOS
......................................................................
[thirdparty] fix Postgres memset_s() build issue on macOS
This changelist adds an extra patch from PostgreSQL's upstream git repo
to address compilation error on macOS after the recent update in Kudu's
3rd-party to enable building with GCC 15 [2]:
thirdparty/src/postgresql-17.2/src/port/explicit_bzero.c:22:9: error:
call to undeclared function 'memset_s'; ISO C99 and later do not
support implicit function declarations
[-Wimplicit-function-declaration]
22 | (void) memset_s(buf, len, 0, len);
Also, it updates the CFLAGS used to build PostgreSQL: keeping the flags
compatible with GCC 7, it switches the default C standard mode
from C17 to C11, replacing -std=c17 with -std=c11.
[1] https://github.com/postgres/postgres/commit/12eee85e5
[2] https://github.com/apache/kudu/commit/2acbccb8c
Change-Id: I88651ddd056c90c02f65148905c61eb0f4e54f94
Reviewed-on: http://gerrit.cloudera.org:8080/24964
Tested-by: Kudu Jenkins
Reviewed-by: Zoltan Martonka <[email protected]>
---
M thirdparty/build-definitions.sh
A thirdparty/patches/postgres-memset_s.patch
M thirdparty/vars.sh
3 files changed, 183 insertions(+), 2 deletions(-)
Approvals:
Kudu Jenkins: Verified
Zoltan Martonka: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/24964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I88651ddd056c90c02f65148905c61eb0f4e54f94
Gerrit-Change-Number: 24964
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Zoltan Martonka <[email protected]>
