Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24963 )
Change subject: [util] an update on --never_fsync flag usage ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/24963/2/src/kudu/util/env-test.cc File src/kudu/util/env-test.cc: http://gerrit.cloudera.org:8080/#/c/24963/2/src/kudu/util/env-test.cc@1340 PS2, Line 1340: NSTANTIATE_TEST_SUITE_P(SyncFlags, : FsSyncControlTest, : ::testing::Combine(testing::Bool(), testing::Bool())); > nit: to improve readability of the test names, consider adding a name gener Done http://gerrit.cloudera.org:8080/#/c/24963/2/src/kudu/util/env-test.cc@1358 PS2, Line 1358: FLUSH_SYNC > nit: here and at line 1376 - consider adding FLUSH_ASYNC variant of tests a IMO this is out of the scope of this changelist. It may be a good venue for a separate changelist which adds test coverage for Env::{RW,Writable}File flush modes' behavior. http://gerrit.cloudera.org:8080/#/c/24963/2/src/kudu/util/env-test.cc@1379 PS2, Line 1379: > nit: Maybe add a unit test for SyncDir() as well. Done -- To view, visit http://gerrit.cloudera.org:8080/24963 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I637e3bd98da98495a38f78176a4a862ab6ae8dd3 Gerrit-Change-Number: 24963 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Thu, 01 Oct 2026 18:27:29 +0000 Gerrit-HasComments: Yes
