Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/25005 )
Change subject: [auto_rebalancer] enforce per-server move cap ...................................................................... Patch Set 2: Code-Review+1 (6 comments) LGTM overall, a view nits. http://gerrit.cloudera.org:8080/#/c/25005/2/src/kudu/master/auto_rebalancer-test.cc File src/kudu/master/auto_rebalancer-test.cc: http://gerrit.cloudera.org:8080/#/c/25005/2/src/kudu/master/auto_rebalancer-test.cc@1735 PS2, Line 1735: // The --auto_rebalancing_max_moves_per_server cap counts each server's moves : // (as source or destination) separately, but GetMovesUsingRebalancingAlgo only : // bounds the whole batch at max_moves_per_server * num_tservers, so one server : // can source several moves in a single batch even with the cap set to 1. Please update the description to be more explicit that the issue is now fixed. http://gerrit.cloudera.org:8080/#/c/25005/2/src/kudu/master/auto_rebalancer-test.cc@1746 PS2, Line 1746: const int kNumOrigTservers = 3; : const int kNumAdditionalTservers = 3; : const int kNumTablets = 12; nit: make these constexpr ? http://gerrit.cloudera.org:8080/#/c/25005/2/src/kudu/master/auto_rebalancer-test.cc@1775 PS2, Line 1775: raw_info = rebalance::ClusterRawInfo(); It'd be cleaner to use a scope-local rebalance::ClusterRawInfo variable instead, and assign it to the outside 'raw_info' after ASSERT_FALSE(). http://gerrit.cloudera.org:8080/#/c/25005/2/src/kudu/master/auto_rebalancer-test.cc@1808 PS2, Line 1808: static_cast<int>( nit: will it work without this extra cast? http://gerrit.cloudera.org:8080/#/c/25005/2/src/kudu/master/auto_rebalancer-test.cc@1814 PS2, Line 1814: NO_PENDING_FATALS(); What is this for? In other words, where do we expect any pending fatals coming from at this point? Please add a comment if there is anything expected. BTW, if using AI tools for generating the code, it's a good idea to reflect that in the commit description. http://gerrit.cloudera.org:8080/#/c/25005/2/src/kudu/master/auto_rebalancer.cc File src/kudu/master/auto_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/25005/2/src/kudu/master/auto_rebalancer.cc@498 PS2, Line 498: rep_moves.back() nit: SelectReplicaToMove() should return non-OK status when not a single move found, but it wouldn't hurt to add DCHECK(!rep_moves.empty()) to stipulate on this invariant -- To view, visit http://gerrit.cloudera.org:8080/25005 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f6b9b200c24d215435329a37e953d75fe923c02 Gerrit-Change-Number: 25005 Gerrit-PatchSet: 2 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 09 Oct 2026 21:37:45 +0000 Gerrit-HasComments: Yes
