Todd Lipcon has posted comments on this change.

Change subject: rpcz: break out trace metrics into separate PB fields
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3092/1/src/kudu/rpc/rpcz_store.cc
File src/kudu/rpc/rpcz_store.cc:

Line 157:                                     const std::string& child_path,
> Nit: don't need std:: prefix
Done


Line 169:   for (const auto& child_pair : t.ChildTraces()) {
> Is it weird that ChildTraces() and Get() are performed non-atomically w.r.t
Sure, it's possible, but I don't think it matters, especially since the normal 
use case here is sampling RPCs which have already completed (and thus these 
things aren't likely to change). Worst case you'd get an inconsistent-looking 
sample on rare occasion, but shouldn't have any possibility of crashes.


-- 
To view, visit http://gerrit.cloudera.org:8080/3092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bd1a249b2f09f8eb63bc64de55147b3d7738a9c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to