Todd Lipcon has posted comments on this change. Change subject: KUDU-1386 NaN float and double values are not handled correctly ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3142/2/src/kudu/common/types.h File src/kudu/common/types.h: Line 303: } else if (isnan(*lhs_n)) { given that nans are less common than anything else, I think it would be best to do an 'else if (*lhs_n == *rhs_n) { return 0; } else { ... nan handing ... }' here, so most common case comes first. Line 334: const double *lhs_n = reinterpret_cast<const double *>(lhs); can you extract this code into a FloatCompare<T> templated method? -- To view, visit http://gerrit.cloudera.org:8080/3142 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I194dcddeb8eabcc67699661b9cc9362a99f2f4ae Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
