Dan Burkert has posted comments on this change.

Change subject: KUDU-1386 NaN float and double values are not handled correctly
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3142/1/src/kudu/common/types.h
File src/kudu/common/types.h:

Line 53:   NONCOMPARABLE = 12
> I'm not sold on NaN being not comparable. Postgres says:
I disagree.  Postgres is clearly doing the wrong thing here because of a 
technical limitation that Kudu doesn't share.  I think there is a 
best-of-both-worlds approach we can take at the cost of a bit more code.  
Instead of having a generic Compare function that returns an integer, we can 
have LessThan, LessThanEquals, Equals, GreaterThan, and GreaterThanEquals 
methods, which are simpler because they don't have to deal with NaN special 
cases.

Adding float/double as an indexible type would change my mind, but I think 
making it non-indexible is the right choice.


-- 
To view, visit http://gerrit.cloudera.org:8080/3142
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I194dcddeb8eabcc67699661b9cc9362a99f2f4ae
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wdberke...@gmail.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to