Will Berkeley has posted comments on this change.

Change subject: KUDU-745 / KUDU-1463 tablet's table id attribute is empty string
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/3183/2//COMMIT_MSG
Commit Message:

Line 12: versus the master's /tables. Is this expected?
> can you give an example? it doesn't seem expected to me :)
Um...it may have just been getting late. Looks fine now, and the test passes.


Line 16: is "sys.catalog".
> I think we should do something to distinguish the ID from the name here.
Done.


http://gerrit.cloudera.org:8080/#/c/3183/2/src/kudu/tablet/tablet-harness.h
File src/kudu/tablet/tablet-harness.h:

Line 92:                                                "KuduTableTest",
> distinguish the ID from the name to make it more clear in logs, etc
Done.


http://gerrit.cloudera.org:8080/#/c/3183/2/src/kudu/tablet/tablet.cc
File src/kudu/tablet/tablet.cc:

Line 178:     //attrs["table_id"] = "booya";
> dead code?
...whoops


-- 
To view, visit http://gerrit.cloudera.org:8080/3183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1795a176312f6c2a55c34b7b684ee408f1cf8732
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wdberke...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to