Jean-Daniel Cryans has submitted this change and it was merged.

Change subject: catalog_manager: move VLOG(1) messages above Async RPC calls to 
avoid crash
......................................................................


catalog_manager: move VLOG(1) messages above Async RPC calls to avoid crash

Several functions in this file used a pattern of sending an Async RPC, followed
by logging that the RPC had been sent. However, the callback for the async RPC
could delete the 'this' instance, which would cause the log message to crash.

This only showed up as flakiness in Java unit tests, because they set --v=1
and these messages were VLOG(1).

Change-Id: Ic6beaf940fe42a0c7a3aa5877b7ef65136af210b
Reviewed-on: http://gerrit.cloudera.org:8080/3181
Reviewed-by: Jean-Daniel Cryans
Tested-by: Kudu Jenkins
(cherry picked from commit 2a34d81f84529bc307dd494dbc2c952b3256aa65)
Reviewed-on: http://gerrit.cloudera.org:8080/3188
---
M src/kudu/master/catalog_manager.cc
1 file changed, 8 insertions(+), 8 deletions(-)

Approvals:
  Jean-Daniel Cryans: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3188
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6beaf940fe42a0c7a3aa5877b7ef65136af210b
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-0.9.x
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins

Reply via email to