Adar Dembo has posted comments on this change.

Change subject: Move the PbTracer in rpc_context.cc to pb_util
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3194/1/src/kudu/util/pb_util.h
File src/kudu/util/pb_util.h:

Line 431: class PbTracer : public debug::ConvertableToTraceFormat {
Since you're making this more "public" than it was before (i.e. not buried in 
rpc_context.cc), could you add comments to the methods explaining what they do, 
and perhaps a class comment explaining how to use this thing?


-- 
To view, visit http://gerrit.cloudera.org:8080/3194
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib601deea9fe0dcc6e2428416a6993c7567ff7335
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <david.al...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to