Adar Dembo has posted comments on this change.

Change subject: Reduce verbosity of Java logs
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3203/1/java/kudu-client/src/test/java/org/kududb/client/MiniKuduCluster.java
File java/kudu-client/src/test/java/org/kududb/client/MiniKuduCluster.java:

Line 398:     public ProcessInputStreamLogPrinterRunnable(int port, InputStream 
is) {
If you're going to proceed with this change (and I think you should), could you 
unplumb the 'port' argument from these?


http://gerrit.cloudera.org:8080/#/c/3203/1/java/kudu-client/src/test/resources/log4j.properties
File java/kudu-client/src/test/resources/log4j.properties:

Line 18: INFO
> This I'm less sure about. It's hard to debug without DEBUG.
What messages will we be missing by requiring INFO or higher?


-- 
To view, visit http://gerrit.cloudera.org:8080/3203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf26651908f533859f16cb4293a06157f9577c7d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to