Adar Dembo has posted comments on this change. Change subject: KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/3102/1/java/kudu-client/src/main/java/org/kududb/client/RowResult.java File java/kudu-client/src/main/java/org/kududb/client/RowResult.java: Line 568: } > What happened here? I think you missed this as well. http://gerrit.cloudera.org:8080/#/c/3102/1/java/kudu-client/src/test/java/org/kududb/client/TestKuduClient.java File java/kudu-client/src/test/java/org/kududb/client/TestKuduClient.java: Line 152: //Do negative testing on string type > Nit: // Do negative... I think you missed this one: please add an empty space between "//" and "Do". Line 154: if (scanner.hasMoreRows()) { > If this is false, we won't actually run the remainder of the test. Shouldn' You didn't address this one either. Line 157: boolean exceptionThrown = false; : try { : next.getInt("c2"); : } catch (ClassCastException e) { : exceptionThrown = true; : } : assertTrue("ClassCastException was not thrown when accessing a string column with getInt", exceptionThrown); : } > Here's a simpler way to do it: Nor this one. -- To view, visit http://gerrit.cloudera.org:8080/3102 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc8c6e5e382ca9f6280072f59acf4257fd13fc6b Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ted Malaska <ted.mala...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
