Adar Dembo has posted comments on this change.

Change subject: Allow to set RequestId in the RPC RequestHeader
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/3179/2/src/kudu/rpc/rpc_controller.h
File src/kudu/rpc/rpc_controller.h:

Line 29: #include "kudu/rpc/rpc_header.pb.h"
If you're storing unique_ptrs to it, you can do a forward declaration of 
RequestIdPB and not need this inclusion.


Line 108:   void SetRequestIdPB(std::unique_ptr<RequestIdPB> request_id);
Documentation? Why would I set this?


Line 179:   // The id of this request.
How long does this last? Looks like when a proxy call is made using this 
controller, it is moved out?


-- 
To view, visit http://gerrit.cloudera.org:8080/3179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I92566250683ee69fad57a9ae694842d4a0b17ab4
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <david.al...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to