David Ribeiro Alves has posted comments on this change.

Change subject: Integrate the ResultTracker into the rpc subsystem and add a 
test
......................................................................


Patch Set 6:

(1 comment)

This is still missing a parallel test for the failure case.

http://gerrit.cloudera.org:8080/#/c/3192/6/src/kudu/rpc/service_if.cc
File src/kudu/rpc/service_if.cc:

Line 103:     ResultTracker::RpcState state = 
ctx->GetResultTracker()->CheckDuplicate(
> It's interesting that 'req' isn't considered at all in CheckDuplicate(). We
that's on purpose. storing the requests is bound to consume much more memory 
that storing the responses so we need to "trust" that the client sends the same 
request with the same seq no. In any case the worst that can happen is that the 
client gets the "wrong" response, if he sent a requests with a previously used 
seq no.


-- 
To view, visit http://gerrit.cloudera.org:8080/3192
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d624810350feceefe244e0319e22cac241bf0d6
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <david.al...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <david.al...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to