Dan Burkert has posted comments on this change.

Change subject: [c++-client]: minimal changes to support tables with 
non-covering range partitions
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3177/1/src/kudu/client/meta_cache.cc
File src/kudu/client/meta_cache.cc:

Line 612:   const TabletLocationsPB& tablet0 = rpc.resp().tablet_locations(0);
> I always thought it was somewhat dangerous to expect any kind of order out 
The only way to not rely on that is to do a partial sort, is that what you 
would prefer?


http://gerrit.cloudera.org:8080/#/c/3177/1/src/kudu/common/partition_pruner.h
File src/kudu/common/partition_pruner.h:

Line 62:   // Used for testing.
> Not true anymore. Update? And what was unsafe/weird about this function to 
It wasn't previously used outside tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/3177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib25b7a57b14b3d1e4e6dca75b88dad7c19ba7565
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to