Todd Lipcon has posted comments on this change.

Change subject: KUDU-1444. Get resource metrics of a scan.
......................................................................


Patch Set 6:

OK. The code now looks good, but missing a test. Sorry, I should have mentioned 
that previously. Maybe add an assertion somewhere in client-test.cc? There are 
lots of scanner tests there, should be able to just check that the metrics show 
up and at least one of the two is > 0.

-- 
To view, visit http://gerrit.cloudera.org:8080/3013
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iedaf570a7601651c93275ae0a8565f1e33da842d
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: zhen.zhang <zhangz...@xiaomi.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: zhen.zhang <zhangz...@xiaomi.com>
Gerrit-HasComments: No

Reply via email to