David Ribeiro Alves has posted comments on this change.

Change subject: WIP: KUDU-1469. Fix handling of fully-deduped requests after a 
leader change
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3228/1/src/kudu/consensus/consensus.proto
File src/kudu/consensus/consensus.proto:

Line 221: last_received
we should probably rename these. this to something to log_head and the below to 
something like last_prepared.


http://gerrit.cloudera.org:8080/#/c/3228/1/src/kudu/consensus/raft_consensus_state.cc
File src/kudu/consensus/raft_consensus_state.cc:

Line 646
would need to change this methods name since it's now updating it conditionally


-- 
To view, visit http://gerrit.cloudera.org:8080/3228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iced21ae1b69c1079efc9aa9cf23e2fa592b8bebd
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <david.al...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-HasComments: Yes

Reply via email to