Misty Stanley-Jones has posted comments on this change.

Change subject: Remove default table partitioning
......................................................................


Patch Set 13:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/3131/13/docs/release_notes.adoc
File docs/release_notes.adoc:

Line 69: - Default table partitioning has been removed. All tables must now be 
created
Should we link to where we show how to create tables?


http://gerrit.cloudera.org:8080/#/c/3131/13/docs/schema_design.adoc
File docs/schema_design.adoc:

Line 163: Kudu does not provide a default partitioning strategy when creating 
tables. It
Enclose this in an admonition by prefixing IMPORTANT: (just before 'Kudu does').


Line 178: distribution keyspace. Range partitioning may be configured to use 
any subset of
With range partitioning, you can divide your tablets using any subset of the 
primary key columns.


http://gerrit.cloudera.org:8080/#/c/3131/13/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java:

Line 299:                                          "setRangePartitionColumns or 
addHashPartitions");
Maybe a little more info in this exception? "To prevent the accidental creation 
of only a single tablet, which will cause bad performance, table partitioning 
must be specified...."


http://gerrit.cloudera.org:8080/#/c/3131/13/java/kudu-client/src/main/java/org/kududb/client/CreateTableOptions.java
File java/kudu-client/src/main/java/org/kududb/client/CreateTableOptions.java:

Line 103:    * partitioning. If the table should only have a single partition 
(not
s/If the table should/To force the use of a single tablet, call...


-- 
To view, visit http://gerrit.cloudera.org:8080/3131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7021d7950f8dbb4918503ea6fab2e6ee35076064
Gerrit-PatchSet: 13
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <david.al...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to