Todd Lipcon has posted comments on this change.

Change subject: KUDU-1444. Get resource metrics of a scan.
......................................................................


Patch Set 7:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/3013/7/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:

Line 268:   void DoTestScanReousrceMetrics(KuduScanner& scanner) {
- typo: "Resource"
- should be a const reference


Line 272: // As all the data are in MRS, both cfile_cache_miss_bytes and 
cfile_cache_miss_bytes are 0
> It seems that all data inserted are in MemeoryRowSet, so when we scan, cfil
Check out TestScanFaultTolerance for an example test where we manually Flush() 
the tablet peer.


Line 273:     ASSERT_TRUE(metrics["cfile_cache_miss_bytes"] + 
metrics["cfile_cache_hit_bytes"] == 0);
use ASSERT_EQ


-- 
To view, visit http://gerrit.cloudera.org:8080/3013
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iedaf570a7601651c93275ae0a8565f1e33da842d
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: zhen.zhang <zhangz...@xiaomi.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: zhen.zhang <zhangz...@xiaomi.com>
Gerrit-HasComments: Yes

Reply via email to