Dan Burkert has posted comments on this change.

Change subject: KUDU-1470 Exceptions on getting a column value should return 
the column name not the column number
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3231/2/java/kudu-client/src/main/java/org/kududb/client/RowResult.java
File java/kudu-client/src/main/java/org/kududb/client/RowResult.java:

Line 484:       throw new IllegalArgumentException("The requested column 
(name:" + columnSchema.getName() +
I think this should have a space between the colon and column name and index, 
e.g. "(name: foo, index: 12)" instead of "(name:foo, index:12)"


Line 493:       throw new IllegalArgumentException("Column (name:" + 
columnSchema.getName() +
here as well.


-- 
To view, visit http://gerrit.cloudera.org:8080/3231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8bb3db1ed7b4e2027814815776f6252b0f749c5
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ted Malaska <ted.mala...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Ted Malaska <ted.mala...@cloudera.com>
Gerrit-HasComments: Yes

Reply via email to