Adar Dembo has posted comments on this change.

Change subject: KUDU-1307 [master] support tables with range partition bounds
......................................................................


Patch Set 11:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2806/11/src/kudu/integration-tests/table_locations-itest.cc
File src/kudu/integration-tests/table_locations-itest.cc:

Line 107:   for (const pair<KuduPartialRow, KuduPartialRow>& bound : bounds) {
        :     encoder.Add(RowOperationsPB::RANGE_LOWER_BOUND, 
std::get<0>(bound));
        :     encoder.Add(RowOperationsPB::RANGE_UPPER_BOUND, 
std::get<1>(bound));
        :   }
Nit: use auto, and use .first/.second instead of get<0>/get<1>


-- 
To view, visit http://gerrit.cloudera.org:8080/2806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04a7ed3e85c993fdbcb313a419f15031103736ce
Gerrit-PatchSet: 11
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to