Adar Dembo has posted comments on this change.

Change subject: Don't use InMemoryEnv in deltafile-test
......................................................................


Patch Set 1:

(1 comment)

Sure. I never cared much for MemEnv; more hassle than good, I think.

The test doesn't get fantastically slower, does it?

http://gerrit.cloudera.org:8080/#/c/3235/1/src/kudu/tablet/deltafile-test.cc
File src/kudu/tablet/deltafile-test.cc:

Line 56: // Can't check on-disk file size with a memenv.
Can remove this code now.


-- 
To view, visit http://gerrit.cloudera.org:8080/3235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I380249e6a72a93e1fde86a551c9d4d32d35904da
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to