Mike Percy has posted comments on this change.

Change subject: log: Mark allocation finished even if allocation had an error
......................................................................


Patch Set 1:

(3 comments)

I'll try to add an isolated test for this

http://gerrit.cloudera.org:8080/#/c/3234/1//COMMIT_MSG
Commit Message:

Line 14: Since this is a bug fix, it seemed cleaner to separate it
       : out into its own commit.
> Really? I think we generally prefer that bugfixes be merged along with thei
Not easy to move the test in with the commit. I'll have to write a new test 
that is isolated to this functionality.

I think the reason there was no test coverage here was because it was 
previously nearly impossible to test the error pathway in a debug build due to 
the DFATALs.


http://gerrit.cloudera.org:8080/#/c/3234/1/src/kudu/consensus/log.cc
File src/kudu/consensus/log.cc:

Line 206:       LOG(FATAL) << "Error syncing log" << s.ToString();
> We talked about this on Slack. I now understand that your goal was to induc
You have a reasonable argument here and I've actually removed the DFATAL 
entirely so we can plumb the error back up the stack.


Line 249:     boost::lock_guard<boost::shared_mutex> 
lock_guard(allocation_lock_);
> Nit: given the super short scope of the lock guard, I think a variable name
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If22bf946a42d0ec32c35164acd9e6e6cef18dcc3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to