Todd Lipcon has posted comments on this change.

Change subject: Allow to set RequestId in the RPC RequestHeader
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3179/3/src/kudu/rpc/rpc_controller.h
File src/kudu/rpc/rpc_controller.h:

Line 110:   void SetRequestIdPB(std::unique_ptr<RequestIdPB> request_id);
per some comments on an earlier (committed) patch in this series, I think we're 
still being too sloppy on the word "Request" and "RPC" here, which makes the 
interface confusing. For example, the proto now has a call_id and a request_id, 
and it's not obvious that the request_id refers to some higher-level retriable 
operation whereas the call_id is a connection-scoped sequence number.

Any ideas on some new terminology we can introduce for this higher-level 
concept?


-- 
To view, visit http://gerrit.cloudera.org:8080/3179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I92566250683ee69fad57a9ae694842d4a0b17ab4
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <david.al...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <david.al...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to