Todd Lipcon has posted comments on this change.

Change subject: KUDU-1471 NPE in AsyncKuduClient from Spark
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3243/3/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java:

Line 1403:       // The client2tables map is assumed to be populated upon the 
return of the TabletClient
If I understand the bug, it's not about the _return_ of the TabletClient 
object, but rather the _publishing_ of the TabletClient object within the 
ip2client map? i.e there's an assumption that if it's present in ip2client, 
then it's also in client2tablets?

This also makes me wonder whether there's a race in addTabletClient() such that 
a tablet can end up listed in the ArrayList twice.

Any way we can get a test which triggers this race semi-reliably?


-- 
To view, visit http://gerrit.cloudera.org:8080/3243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecb0f0f50f62db3a3d5fb10f80da70fedeb2629d
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ted Malaska <ted.mala...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to