Todd Lipcon has posted comments on this change.

Change subject: Add a RpcContext::RespondFailure() method
......................................................................


Patch Set 6:

(2 comments)

wonder whether it would be a clearer API to instead have a flag like 
context->DoNotCacheResponse(); which must be called in these cases? It gets a 
bit ugly that we have so many different "RespondFailure" code paths now

http://gerrit.cloudera.org:8080/#/c/3191/6/src/kudu/rpc/rpc_context.h
File src/kudu/rpc/rpc_context.h:

Line 84:   // Mark this call as failed but don't actually change the response.
this isn't clear that it also responds -- "Mark as failed" doesn't have the 
active verb "responds"


Line 87:   // to mark the call as failed.
would be good to explain what actual effect this has


-- 
To view, visit http://gerrit.cloudera.org:8080/3191
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f1387ba0f837046a8056e77f73a3982f06c73a2
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <david.al...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <david.al...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to