Jean-Daniel Cryans has posted comments on this change.

Change subject: KUDU-1471 NPE in AsyncKuduClient from Spark
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3243/3/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java:

Line 1403:       // The client2tables map is assumed to be populated upon the 
return of the TabletClient
> If I understand the bug, it's not about the _return_ of the TabletClient ob
addTabletClient() is called while synchronized on the TabletClient's own 
tabletServers. Basically, you can only modify metadata about a logical tablet 
one thread at a time.

A test would indeed be nice, but hard to get in if we want this fix in 0.9.0.


-- 
To view, visit http://gerrit.cloudera.org:8080/3243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecb0f0f50f62db3a3d5fb10f80da70fedeb2629d
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ted Malaska <ted.mala...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to