Dan Burkert has posted comments on this change.

Change subject: Specify guaranteed semantics of GetTableLocations RPC
......................................................................


Patch Set 1:

(3 comments)

There are tests covering the guarantees in table_locations-itest introduced in 
http://gerrit.cloudera.org:8080/#/c/2806/.

http://gerrit.cloudera.org:8080/#/c/3240/1/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

Line 3093: StatusToPB(Status::ServiceUnavailable("Tablet not running"),
         :                  resp->mutable_error()->mutable_status());
> no 'break' here?
Done


Line 3093: StatusToPB(Status::ServiceUnavailable("Tablet not running"),
         :                  resp->mutable_error()->mutable_status());
> BuildLocationsForTablet() can also return Status::NotFound for deleted tabl
Deleted tablets should be filtered out of the response, regardless if they were 
deleted because of failed bootstrapping, or because of a drop range partition 
operation.  I've updated the code accordingly.


http://gerrit.cloudera.org:8080/#/c/3240/1/src/kudu/master/master.proto
File src/kudu/master/master.proto:

Line 415: non-covered ranges
> How about a bullet point saying this explicitly (i.e. a gap in range covera
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3240
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc2b5b647e33c0ee8fc052192870f814eff8c178
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to