Adar Dembo has posted comments on this change.

Change subject:  fix compile error when compiling column_predicate-test.cc
......................................................................


Patch Set 8:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3233/8//COMMIT_MSG
Commit Message:

Line 7:  fix compile error when compiling column_predicate-test.cc
There's one more formatting issue here: looks like every line in the commit 
description is indented by one character. Can you remove that indentation?


Line 10:  column_predicate-test.cc.
Thanks for the additional detail. I have two follow-up questions:
1. What compiler are you using? What version?
2. Does the compiler pinpoint a particular line in column_predicate-test.cc?

I suspect TestInclusiveRange because the ASSERTs there compare 
boost::optional<ColumnPredicate> to ColumnPredicate. If that's true, we should 
fix that by modifying the test itself instead of providing this overload.


-- 
To view, visit http://gerrit.cloudera.org:8080/3233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f9a9634eeccd86616be80b004ecce596155bb57
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: song bruce zhang <zsyuyizh...@gmail.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: song bruce zhang <zsyuyizh...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to