Adar Dembo has posted comments on this change.

Change subject: Remove InMemoryEnv completely
......................................................................


Patch Set 1:

I think memenv would have been useful had we ever used it in non-trivial tests 
(i.e. tests that perform real I/O). But we never did, and like you said it's a 
tax on env changes, so I agree we should remove it.

Can you check the various license files to see if memenv is mentioned there?

Also, do we still need the env "wrapper" thing found at the bottom of env.h? Or 
is that also unnecessary now?

-- 
To view, visit http://gerrit.cloudera.org:8080/3258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f26e321ec68a15b511db522e4d85470da7905f8
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

Reply via email to