Mike Percy has posted comments on this change. Change subject: Remove InMemoryEnv completely ......................................................................
Patch Set 1: There are no mentions of MemEnv or InMemoryEnv anywhere else in the code base that I could find. For the EnvWrapper, it's not actually used by anything useful. However it does provide a mocking point that could be used when desired and the overhead of adding calls there when adding a new method is very low. So I'm inclined to leave it be. -- To view, visit http://gerrit.cloudera.org:8080/3258 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f26e321ec68a15b511db522e4d85470da7905f8 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-HasComments: No
