Adar Dembo has posted comments on this change.

Change subject: Replace boost::{lock, unique_lock, mutex} with std lib 
equivalents
......................................................................


Patch Set 3: Code-Review+2

(2 comments)

Would be nice to add some "using std::lock_guard" statements into the .cc files 
that fully qualify lock_guard and friends a lot, but that's better done in a 
follow-up.

http://gerrit.cloudera.org:8080/#/c/3262/3/src/kudu/consensus/raft_consensus.h
File src/kudu/consensus/raft_consensus.h:

Line 21: #include <boost/optional/optional_fwd.hpp>
What's this one for?


http://gerrit.cloudera.org:8080/#/c/3262/3/src/kudu/util/boost_mutex_utils.h
File src/kudu/util/boost_mutex_utils.h:

Line 21: // Similar to std::lock_guard except that it takes
       : // a lock pointer, and checks against nullptr. If the
       : // pointer is NULL, does nothing. Otherwise guards
       : // with the lock.
I take it there's no equivalent to this in the STL?


-- 
To view, visit http://gerrit.cloudera.org:8080/3262
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0c27f72c726258793991006a728673af537414bb
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to