Mike Percy has posted comments on this change.

Change subject: Replace kudu::{lock_guard, unique_lock} with std lib equivalents
......................................................................


Patch Set 7: Code-Review+2

On second thought, I agree with Adar that it looks cleaner without the std:: 
prefix, but if you don't feel like adding using std::mutex everywhere them I'm 
ok with leaving it as-is as long as he is. This change is already a win.

-- 
To view, visit http://gerrit.cloudera.org:8080/3271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f9e0f78fed9a35330c0324d1f3bc1c89f6ab47d
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: No

Reply via email to