Adar Dembo has posted comments on this change.

Change subject: KUDU-1308 [c++-client]: support tables with non-covering range 
partitions
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/3255/2/src/kudu/client/client-internal.cc
File src/kudu/client/client-internal.cc:

Line 140:     vector<uint32_t> required_feature_flags) {
> oops, forgot the last plumbing step.
Kind of surprised nothing failed without this. Are we lacking in some test 
coverage?


http://gerrit.cloudera.org:8080/#/c/3255/2/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:

Line 1084:     Status result = session->Flush();
> If you're going to flush with each row, how about using KuduSession::AUTO_F
I think you missed this comment.


http://gerrit.cloudera.org:8080/#/c/3255/2/src/kudu/client/meta_cache.cc
File src/kudu/client/meta_cache.cc:

Line 811:   ts_cache_.clear();
> Done
Surprised ASAN didn't complain about this. More missing test coverage?


http://gerrit.cloudera.org:8080/#/c/3255/2/src/kudu/client/scanner-internal.cc
File src/kudu/client/scanner-internal.cc:

Line 308: else if (!s.ok()) {
        :       return s;
        :     }
> Done
You don't need the 'else' statement either.


-- 
To view, visit http://gerrit.cloudera.org:8080/3255
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1cb12704c5e9792ee6e5831568bc52b1a713f8d5
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to