Dan Burkert has posted comments on this change.

Change subject: Add TableCreator::add_range_split and deprecate 
TableCreator::split_rows
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3275/2//COMMIT_MSG
Commit Message:

Line 9: TableCreator::split_rows took a vector<const KuduPartialRow*>, which 
make it
> Nit: made, not make
I changed this whole thing to present tense since it's not going away yet.


http://gerrit.cloudera.org:8080/#/c/3275/2/src/kudu/client/client.h
File src/kudu/client/client.h:

Line 359:   // If the row is missing a value for any of the range partition 
column, the
> Nit: range partition columns?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72cc152ff4b01834abd3c7b6fc32980ceb789c69
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to