Dan Burkert has submitted this change and it was merged.

Change subject: fix compile error when compiling column_predicate-test.cc
......................................................................


fix compile error when compiling column_predicate-test.cc

The test does not compile against boost 1.56. The error message is:

  gtest-printers.h:245: undefined reference to `std::basic_ostream<char,
  std::char_traits<char>>& boost::operator<< <char,std::char_traits<char>
  ,kudu::ColumnPredicate>>(std::basic_ostream<char,
  std::char_traits<char>>&, boost::optional<kudu::ColumnPredicate> const&)`

It appears to be https://svn.boost.org/trac/boost/ticket/10825, but
including optional_io.hpp in column_predicate.h (the purported workaround)
yields a different compile error:

  operator<<: cannot bind lvalue to 'std::basic_ostream<char>&&'

Rather than defining operator<< in ColumnPredicate, let's just modify the
ASSERTs in the test. I don't understand gtest macros well enough to know why
this helps, but I've verified that the modified test compiles and passes
when built against boost 1.56 and 1.58.

Change-Id: I6f9a9634eeccd86616be80b004ecce596155bb57
Reviewed-on: http://gerrit.cloudera.org:8080/3233
Tested-by: Kudu Jenkins
Reviewed-by: song bruce zhang <zsyuyizh...@gmail.com>
Reviewed-by: Dan Burkert <d...@cloudera.com>
---
M src/kudu/common/column_predicate-test.cc
1 file changed, 7 insertions(+), 7 deletions(-)

Approvals:
  Dan Burkert: Looks good to me, approved
  song bruce zhang: Looks good to me, but someone else must approve
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6f9a9634eeccd86616be80b004ecce596155bb57
Gerrit-PatchSet: 11
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: song bruce zhang <zsyuyizh...@gmail.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: song bruce zhang <zsyuyizh...@gmail.com>

Reply via email to