Dan Burkert has submitted this change and it was merged.

Change subject: Add TableCreator::add_range_split and deprecate 
TableCreator::split_rows
......................................................................


Add TableCreator::add_range_split and deprecate TableCreator::split_rows

TableCreator::split_rows takes a vector<const KuduPartialRow*>, which makes it
very difficult for the calling application to do proper error handling with
cleanup when setting the fields of the partial row. Taking the range split rows
one by one allows the application to wrap the partial row in a unique_ptr 'end
to end', and handle errors correctly. client-test has been updated to use the
new API, and now handles errors correctly when initializing split rows.

Change-Id: I72cc152ff4b01834abd3c7b6fc32980ceb789c69
Reviewed-on: http://gerrit.cloudera.org:8080/3275
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <a...@cloudera.com>
---
M src/kudu/client/client-test.cc
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/table_creator-internal.cc
M src/kudu/client/table_creator-internal.h
5 files changed, 43 insertions(+), 30 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I72cc152ff4b01834abd3c7b6fc32980ceb789c69
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>

Reply via email to