Adar Dembo has posted comments on this change.

Change subject: Improve tpch usability
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3279/1/src/kudu/scripts/tpch.sh
File src/kudu/scripts/tpch.sh:

Line 70:   $ROOT/src/kudu/scripts/ensure_cpu_scaling.sh "$@"
> To clarify, the script expected me to run from $ROOT but I ran from $ROOT/b
So $BASH_SOURCE doesn't actually yield absolute paths? Didn't know that.

How about this instead:
  $(cd $(dirname $BASH_SOURCE) && pwd)/ensure_cpu_scaling.sh "$@"

The advantage is that we haven't hardcoded a subdirectory tree into the call, 
so it'll be less stuff to update if the scripts are moved.


-- 
To view, visit http://gerrit.cloudera.org:8080/3279
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I604b0f7433781be78d76ca34f3e30e49ddeca6a8
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-HasComments: Yes

Reply via email to