Dan Burkert has posted comments on this change.

Change subject: KUDU-1308 [c++-client]: support tables with non-covering range 
partitions
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/3255/2/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:

PS2, Line 1061: ASSERT_NO_FATAL_FAILURE(InsertTestRows(table.get(), 50, 0));
              :   client_->data_->meta_cache_->ClearCacheForTesting();
              :   ASSERT_NO_FATAL_FAILURE(InsertTestRows(table.get(), 50, 50));
              :   client_->data_->meta_cache_->ClearCacheForTesting();
              :   ASSERT_NO_FATAL_FAILURE(InsertTestRows(table.get(), 100, 
200));
              :   client_->data_->meta_cache_->ClearCacheForTesting();
> What's the significance of clearing the cache? Add a comment?
Done


Line 1068:   // Insert an out-of-range rows
> Nit: no need for 'an'.
Done


Line 1084:     Status result = session->Flush();
> I think you missed this comment.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3255
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1cb12704c5e9792ee6e5831568bc52b1a713f8d5
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to