Todd Lipcon has posted comments on this change.

Change subject: KUDU-1446 Consider data types in predicate evaluation order
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3298/2/src/kudu/common/column_predicate.cc
File src/kudu/common/column_predicate.cc:

Line 360:   rank *= 10;
how about:

return rank * (kLargestTypeSize + 1) + predicate.column().type_info()->size();

and then this list doesn't have to be manually maintained?


-- 
To view, visit http://gerrit.cloudera.org:8080/3298
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c3388876035cb494fdb2c0e1f17698f089fdf72
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wdberke...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to