Will Berkeley has posted comments on this change.

Change subject: KUDU-1446 Consider data types in predicate evaluation order
......................................................................


Patch Set 3:

(1 comment)

> Also a unit test here would be nice (isn't there a test somewhere
 > that tests the sorting?)

I didn't see a test for it. I added a little one.

http://gerrit.cloudera.org:8080/#/c/3298/2/src/kudu/common/column_predicate.cc
File src/kudu/common/column_predicate.cc:

Line 360: } // anonymous namespace
> how about:
Done.


-- 
To view, visit http://gerrit.cloudera.org:8080/3298
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c3388876035cb494fdb2c0e1f17698f089fdf72
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wdberke...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to