Mike Percy has posted comments on this change.

Change subject: Improve tpch usability
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3279/1/src/kudu/scripts/tpch.sh
File src/kudu/scripts/tpch.sh:

Line 70:   $ROOT/src/kudu/scripts/ensure_cpu_scaling.sh "$@"
> So $BASH_SOURCE doesn't actually yield absolute paths? Didn't know that.
That won't work, because the relative path will be wrong by the time we get 
here (same reason why the previous thing didn't work)

However I could do SCRIPT_DIR=$ROOT/src/kudu/scripts or SCRIPT_DIR=$(cd 
$(dirname $BASH_SOURCE) && pwd) at the top of the file and then use that here. 
However I think the way I wrote it is easy to read and understand, so would 
prefer to leave it as is.


-- 
To view, visit http://gerrit.cloudera.org:8080/3279
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I604b0f7433781be78d76ca34f3e30e49ddeca6a8
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-HasComments: Yes

Reply via email to