Mike Percy has posted comments on this change.

Change subject: Improve tpch usability
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3279/2/src/kudu/scripts/tpch.sh
File src/kudu/scripts/tpch.sh:

Line 129: $ROOT/build/$BUILD_TYPE/bin/tpch1 -logtostderr=1 \
> Why is this necessary? L81 does "cd $ROOT", and the rest of the code here (
Hmm, I think this is a spurious change. But I'm not really a fan of "." in long 
shell scripts like this because it forces one to scroll back and figure out 
where we were before the pushd in this script, for example


Line 133:                                   $* \
> Surprised this doesn't need quoting, or to be "$@" or something. I can neve
Nope, it's fine. This is the one I've always used since pre-bash days. $@ is a 
bash thing and I guess it's an array or something.


-- 
To view, visit http://gerrit.cloudera.org:8080/3279
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I604b0f7433781be78d76ca34f3e30e49ddeca6a8
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-HasComments: Yes

Reply via email to