Adar Dembo has posted comments on this change.

Change subject: kudu-1475: set is is_initialized_ to false in log pre-allocated 
case
......................................................................


Patch Set 3:

(1 comment)

BTW, your tests are failing because this patch is based on one you abandoned 
that has a typo in column_predicate-test (ASSERT_FLASE() instead of 
ASSERT_FALSE()).

http://gerrit.cloudera.org:8080/#/c/3284/2//COMMIT_MSG
Commit Message:

Line 7: kudu-1475: set is is_initialized_ to false in log pre-allocated case
> Nit: rewrite as "KUDU-1475: set is_initialized_ to false in log pre-allocat
I think you missed a few of these changes; it should be KUDU-1475 (in capital 
letters), and "set is is_initialized_" should be "set is_initialized_" (there's 
an extra "is" in there).


-- 
To view, visit http://gerrit.cloudera.org:8080/3284
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I45b2beb7c669b1821be8242f45fcea4c6ae269a0
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: song bruce zhang <zsyuyizh...@gmail.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: song bruce zhang <zsyuyizh...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to