Adar Dembo has posted comments on this change.

Change subject: ts_itest-base.h: wait for bootstrapping to finish when waiting 
for replicas
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/3308/1/src/kudu/integration-tests/external_mini_cluster.cc
File src/kudu/integration-tests/external_mini_cluster.cc:

Line 364:         (min_tablet_count == -1 ||
> isn't this somewhat redundant? i.e the size will always be >= -1
Yeah, will remove.


http://gerrit.cloudera.org:8080/#/c/3308/1/src/kudu/integration-tests/external_mini_cluster.h
File src/kudu/integration-tests/external_mini_cluster.h:

Line 242:                                int min_tablet_count);
> it strikes me that the timeout is usually the last argument, but here's the
I don't feel strongly. Will switch.


http://gerrit.cloudera.org:8080/#/c/3308/1/src/kudu/integration-tests/ts_itest-base.h
File src/kudu/integration-tests/ts_itest-base.h:

Line 180:     // Like the above, an expired deadline is not considered to be a 
failure.
> can you explain this a bit further?
Sure. I've updated the comment.


-- 
To view, visit http://gerrit.cloudera.org:8080/3308
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I116e0bd8ec9d7abbe830d1d0ea4e35465d990a28
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to