Jean-Daniel Cryans has posted comments on this change. Change subject: [java-client] RPC timeout may sometimes be reported as max attempts violation ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3330/2/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java: Line 1004: message = "Time out: "; I wonder if it should be even clearer than that. The reason we got "Too many attempts" before is because were were checking wouldSleepingTimeout() and it was returning true. So we early time out the RPC to respect the configured timeout. So now we get "Time out", except that the log will still show something like "DeadlineTracker(timeout=30000, elapsed=28824)". -- To view, visit http://gerrit.cloudera.org:8080/3330 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c5676ab5bd05170505ef0313b919c5475ae6b37 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
